-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-13853: Added the ability to filter by all to the Advanced Rules page #9371
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @HunterG6700. I noted some code formatting issues, and a labeling recommendation, but I will defer to @mcgilman or @scottyaslan for additional input from a frontend implementation perspective.
return actions; | ||
} | ||
} else if (filterType.value === 'action') { | ||
var actions = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation appears to be off in this new block, in comparison with the other blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you I didn't notice that I thought my IDE auto formatted it.
@@ -201,6 +201,9 @@ var ua = { | |||
}, { | |||
text: 'by action', | |||
value: 'action' | |||
}, { | |||
text: 'filter everything', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the existing pattern, it seems like it would be better to call this by any field
or by any property
.
0732c6d
to
b319bb0
Compare
Summary
NIFI-13853
Added the ability to filter on text anywhere in the UpdateAttribute advanced rules. Currently you can filter by matching text in Rule name, the Conditions, Comments, and the Actions. So I added an option to filter "Anywhere", if the search string matches anywhere in a rule, that rule will be displayed.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation